[libcxx-commits] [PATCH] D131364: [libc++][test] Mark `test_comparisons.h` helpers as nodiscard

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 11 01:18:00 PDT 2022


philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

You shouldn't use libc++-specific macros in the tests. Instead, add a new macro to `test_macros.h` and use it here. Otherwise the tests that use `test_comparisons.h` would break for other implementations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131364/new/

https://reviews.llvm.org/D131364



More information about the libcxx-commits mailing list