[libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates updated this revision to Diff 451704.
mumbleskates marked 6 inline comments as done.
mumbleskates added a comment.

- correctly wrap testOrder and testComparisons in asserts
- fix nits
- run git clang-format on all changes
- manually clang-format the added function
- manually fix spacing of multiline macros
- add partial_ordering::unordered test cases & utils support
- refactor testComparisons and clean up includes
- add nodiscard vis a vis D131364 <https://reviews.llvm.org/D131364>
- order things sensibly because this is C++


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131372/new/

https://reviews.llvm.org/D131372

Files:
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/include/__variant/monostate.h
  libcxx/include/variant
  libcxx/test/std/utilities/variant/variant.monostate.relops/relops.pass.cpp
  libcxx/test/std/utilities/variant/variant.relops/three_way.pass.cpp
  libcxx/test/support/test_comparisons.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131372.451704.patch
Type: text/x-patch
Size: 48982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220811/3b87d8be/attachment-0001.bin>