[libcxx-commits] [PATCH] D129399: [libcxx] [test] Merge the experimental-lib-exports testcases into static-lib-exports

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 10 09:32:07 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, modulo some nits. Can you validate whether it still passes the CI before landing.



================
Comment at: libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp:11
 
 // This file checks that the built static library doesn't contain dllexport
 // directives in clang-cl builds.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129399/new/

https://reviews.llvm.org/D129399



More information about the libcxx-commits mailing list