[libcxx-commits] [PATCH] D131315: [libc++] Implement P2273R3 (`constexpr` `unique_ptr`)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

SGTM, but some requests remain, once done I'll have a closer look; probably next weekend.



================
Comment at: libcxx/include/memory:409
     constexpr default_delete() noexcept = default;
-    template <class U> default_delete(const default_delete<U>&) noexcept;
+    template <class U> default_delete(const default_delete<U>&) noexcept; // constexpr since C++23
 
----------------
We normally add the constexpr to the wording too, that way the wording in the synopsis matches the Standard. (Except we don't remove entries.)


================
Comment at: libcxx/test/support/test_comparisons.h:32
 //  Test all six comparison operations for sanity
 template <class T, class U = T>
+TEST_CONSTEXPR_CXX14 bool testComparisons(const T& t1, const U& t2, bool isEqual, bool isLess) {
----------------
Can you mention what changed in this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131315/new/

https://reviews.llvm.org/D131315