[libcxx-commits] [PATCH] D131498: [libc++][NFC] Rename the constexpr macros

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang accepted this revision.
avogelsgesang added a comment.

LGTM, thanks!

I didn't actually look through all the files, I only looked at a random sample. I trust that you made the changes using `sed` or some other automation, and that the test cases would catch any functional regressions



================
Comment at: libcxx/.clang-format:18
+                  '_LIBCPP_CONSTEXPR_CXX20',
                   '_LIBCPP_CONSTEXPR_AFTER_CXX20',
                   '_LIBCPP_ALIGNOF',
----------------
not sure what the outcome of the Discord discussion was (somehow I can't find the channel anymore?), but personally I would prefer to also change `_LIBCPP_CONSTEXPR_AFTER_CXX20` to `_LIBCPP_CONSTEXPR_CXX23`

Please don't let this stop you from merging your change though. It is a clear improvement compared to the previous state


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131498/new/

https://reviews.llvm.org/D131498