[libcxx-commits] [PATCH] D130668: [libunwind] Use `_dl_find_object` if available

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: libunwind/src/AddressSpace.hpp:640
+
+    // `_dl_find_object` gives us the start of the PT_GNU_EH_FRAME section.
+    info.dwarf_index_section =
----------------
avogelsgesang wrote:
> MaskRay wrote:
> > No need to replicate the member variable name. Just say "Record the start of PT_GNU_EH_FRAME"
> > 
> > PT_GNU_EH_FRAME is not a section.
> Thanks for catching this! :)
End full sentences with a period.


================
Comment at: libunwind/src/AddressSpace.hpp:614
+#endif
+  // We expect `_dl_find_object` to return the the PT_GNU_EH_FRAME section.
+#if DLFO_EH_SEGMENT_TYPE != PT_GNU_EH_FRAME
----------------
MaskRay wrote:
> typo: `the the`
PT_GNU_EH_FRAME is not a section.

"return PT_GNU_EH_FRAME" should suffice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130668/new/

https://reviews.llvm.org/D130668