[libcxx-commits] [PATCH] D131357: [libc++] Implement `operator<=>` for `type_index`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: libcxx/test/std/utilities/type.index/type.index.members/cmp.pass.cpp:48
+  // Test `t1` and `t3` which are not equal
+  bool isLess = t1 < t3;
+  assert(testComparisons(t1, t3, /*isEqual*/ false, isLess));
----------------
avogelsgesang wrote:
> Mordante wrote:
> > We use snake-case in our tests.
> only for variable names or also for function names?
Both, but we're not always consistent ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131357/new/

https://reviews.llvm.org/D131357