[libcxx-commits] [PATCH] D131326: [libc++][ranges] Sets ranges feature-test macro.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const accepted this revision.
var-const added a comment.

LGTM with one comment.



================
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp:260
 #   ifdef __cpp_lib_ranges
-#     error "__cpp_lib_ranges should not be defined because it is unimplemented in libc++!"
+#     error "__cpp_lib_ranges should not be defined when !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES) is not defined!"
 #   endif
----------------
Is this correct? Reading aloud, it seems to say `when not defined ... is not defined`. The exclamation mark looks unnecessary, and perhaps the first `defined` is unnecessary as well -- would it read better as `should not be defined when _LIBCPP_HAS_NO_INCOMPLETE_RANGES is not defined`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131326/new/

https://reviews.llvm.org/D131326