[libcxx-commits] [PATCH] D131372: Implement std::variant::operator<=>

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates added inline comments.


================
Comment at: libcxx/include/variant:1644
+template <class... _Types> requires (three_way_comparable<_Types> && ...)
+inline _LIBCPP_INLINE_VISIBILITY constexpr
+common_comparison_category_t<compare_three_way_result_t<_Types>...>
----------------
mumbleskates wrote:
> Mordante wrote:
> > `inline` isn't needed here, both a template and constexpr imply that.
> Should `inline` therefore be removed from all of these operators?
this whole file is only C++17 onward; i am less familiar with the progression of the associated keyword rules. should we have a separate differential to fix this if it's widespread within this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131372/new/

https://reviews.llvm.org/D131372