[libcxx-commits] [PATCH] D131430: [libc++] Implement `thread::id` comparators as free functions

Adrian Vogelsgesang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 8 13:10:42 PDT 2022


avogelsgesang created this revision.
avogelsgesang added reviewers: Mordante, ldionne, philnik.
Herald added a project: All.
avogelsgesang requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

So far, the `thread::id` comparators were implemented as hidden friends.
This was non-conforming and lead to incorrectly rejected C++ code, as
can be seen in the linked Github issue.

Fixes https://github.com/llvm/llvm-project/issues/56187


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131430

Files:
  libcxx/include/__threading_support
  libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/eq.pass.cpp
  libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/lt.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131430.450915.patch
Type: text/x-patch
Size: 4933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220808/d6012702/attachment.bin>


More information about the libcxx-commits mailing list