[libcxx-commits] [PATCH] D131362: [libc++] Implement `operator<=> for `thread::id`

Mon Aug 8 10:23:41 PDT 2022

avogelsgesang planned changes to this revision.
avogelsgesang added a comment.

I first need to fix https://github.com/llvm/llvm-project/issues/56187 and will come back to this patch afterwards

================
Comment at: libcxx/include/__threading_support:651
+#else // _LIBCPP_STD_VER <= 17
+    friend _LIBCPP_INLINE_VISIBILITY
+        strong_ordering operator<=>(__thread_id __x, __thread_id __y) noexcept
----------------
Mordante wrote:
> avogelsgesang wrote:
> > Mordante wrote:
> > > Mordante wrote:
> > > > I read your reasoning about why you did it, but I think we should fix it. There's already a bug report regarding this issue.
> > > > https://github.com/llvm/llvm-project/issues/56187
> > > For new code please use `_LIBCPP_HIDE_FROM_ABI` instead, both do the same but this name is the new name.
> > Do you want me to turn the friends into non-friends as part of this commit or should I use a separate commit for this?
> I prefer a separate commit for the unfriending, but I like to do the spaceship operator the proper way.
> Feel free to assign the bug to yourself I haven't started it; I mainly self-assigned since I intended to work on the spaceship operators. But I have enough other things on my todo list.
ok, I will fix this bug in a separate commit, then, and come back to this change here after fixing it

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131362/new/

https://reviews.llvm.org/D131362