[libcxx-commits] [PATCH] D131322: [libc++] Fixes string_view comparison operators.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/common_type_specialization.pass.cpp:9
+
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14)
+
----------------
huixie90 wrote:
> question : why !stdlib=libc++
libc++ provides `string_view` in all language Standards, other vendors only in C++17. So this disables the testing before C++17 when the library isn't libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131322/new/

https://reviews.llvm.org/D131322