[libcxx-commits] [PATCH] D131292: [libunwind][AIX] Save/restore errno before/after system calls dlopen/dlsym/dlclose

Hubert Tong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 8 09:42:55 PDT 2022


hubert.reinterpretcast added a comment.

In D131292#3706835 <https://reviews.llvm.org/D131292#3706835>, @compnerd wrote:

> I'm not opposed to the change, but I wonder if we should consider placing this in an `#if defined(_AIX)` guard.  This would avoid touching `errno` on other platforms, which would likely be a TLS access.  It would also make it more obvious that this is a workaround for AIX.  At the very least, I think that we should add some comments to explain the issue so that it is obvious at the site rather than having to go through the change log.

`errno` for other platforms should be untouched anyway... `_LIBUNWIND_SUPPORT_TBTAB_UNWIND` is only true (AFAIK) for AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131292/new/

https://reviews.llvm.org/D131292



More information about the libcxx-commits mailing list