[libcxx-commits] [PATCH] D131037: [libc++] Simplify how we define the linker script for libc++

Mon Aug 8 07:03:42 PDT 2022

ldionne added a comment.

In D131037#3704812 <https://reviews.llvm.org/D131037#3704812>, @dim wrote:

> So I've been trying again with the following diff applied on top of this one:
>
> [...]
>
> At this point I'm inclined to just do the test builds with `LIBCXX_CXX_ABI` forced to `libcxxabi`, as the runtimes seem to be pretty much broken for anything other than libcxxabi. :-)

Thanks for digging deeper here. However, I'll admit that I am not willing to keep shooting in the dark with random fixes. Instead, can you **please** pick up D128084 <https://reviews.llvm.org/D128084> so we can start testing on FreeBSD? Most of the work has been done already, it just needs a bit of polishing that will be much easier to do with access to a FreeBSD machine locally.

I think this is an excellent example of what I've been saying with respect to untested platforms meaning they are not supported. I really want to provide proper support for FreeBSD, but it's literally impossible to do so if we don't have CI for that platform. We should have CI that builds on FreeBSD against the system `libcxxrt` ABI library like you do in the releases and none of this release-time churn would happen.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131037/new/

https://reviews.llvm.org/D131037