[libcxx-commits] [PATCH] D131315: [libc++] Implement P2273R3 (`constexpr` `unique_ptr`)

[Igor Zhukov via Phabricator via libcxx-commits]

fsb4000 marked an inline comment as done.
fsb4000 added a comment.

I renamed the revision but I'm still unsure if these tests are enough.



================
Comment at: libcxx/include/__memory/unique_ptr.h:36
-    static_assert(!is_function<_Tp>::value,
-                  "default_delete cannot be instantiated for function types");
 #ifndef _LIBCPP_CXX03_LANG
----------------
Mordante wrote:
> In general we only format the changes in the diff instead of the entire file. That makes reviewing a bit easier.
> (Unlike MSVC STL we (IMO unfortunately) haven't applied clang-format to our entire code base.)
Yes, sorry :(
I updated unique_ptr.h without clang-format so it should be easier for review now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131315/new/

https://reviews.llvm.org/D131315