[libcxx-commits] [PATCH] D130861: [libc++] Implement `operator==` for `filesystem::space_info`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

LGTM, except for the missing constexpr test. I want to see that before approving.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/space_info.pass.cpp:27
+
+  assert(testEquality(space_info{1, 2, 3}, space_info{1, 2, 3}, true));
+  assert(testEquality(space_info{0, 2, 3}, space_info{1, 2, 3}, false));
----------------
Please also test as `constexpr` since the defaulted is a constexpr function. (http://eel.is/c++draft/class.compare.default#4)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130861/new/

https://reviews.llvm.org/D130861