[libcxx-commits] [PATCH] D131322: [libc++] Fixes string_view comparison operators.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Mordante added a reviewer: philnik.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

While implementing `operator<=>` for `string_view` (D130295 <https://reviews.llvm.org/D130295>) @philnik
pointed out `common_type` should be `type_identity`. Since it was an
existing issue that wasn't addressed.

This addresses the issue for both the new and existing equality and
comparison operators. The test is based on the example posted in
D130295 <https://reviews.llvm.org/D130295>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131322

Files:
  libcxx/include/string_view
  libcxx/test/std/strings/string.view/string.view.comparison/common_type_specialization.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131322.450521.patch
Type: text/x-patch
Size: 8070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220806/ca4c84f1/attachment.bin>