[libcxx-commits] [PATCH] D131215: [libc++][NFC] Remove TEST_HAS_NO_SPACESHIP_OPERATOR

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 5 11:21:18 PDT 2022


ldionne accepted this revision.
ldionne added a subscriber: CaseyCarter.
ldionne added a comment.
This revision is now accepted and ready to land.

I think this should be fine -- MSVC definitely implements it nowadays and they use our test suite to run against their ToT compiler+stdlib (this is an assumption but it seems like a safe assumption to make).

@CaseyCarter Do you see a problem with this patch?

Please feel free to ship this if Casey's fine with it or if there's no answer by next Tuesday, I don't think this will cause any issues for them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131215/new/

https://reviews.llvm.org/D131215



More information about the libcxx-commits mailing list