[libcxx-commits] [PATCH] D129968: [libc++] Add a bunch of missing _LIBCPP_HIDE_FROM_ABI

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 4 10:20:48 PDT 2022


Mordante added a comment.

In D129968#3699835 <https://reviews.llvm.org/D129968#3699835>, @ldionne wrote:

> In D129968#3693940 <https://reviews.llvm.org/D129968#3693940>, @Mordante wrote:
>
>> Validate all `main` functions in the tests have the proper signature and have a `return 0;`.
>
> If we go there, we might as well check that `main` is declared as `int main(int, char**)` (and not `void main(...)` or `int main(int, char const**` or other variations).

Agreed, that's what I meant with the proper signature ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129968/new/

https://reviews.llvm.org/D129968



More information about the libcxx-commits mailing list