[libcxx-commits] [PATCH] D130295: [libc++] Uses operator<=> in string_view

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 4 09:36:13 PDT 2022


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nit.



================
Comment at: libcxx/include/string_view:803
+            "return type is not a comparison category type");
+        return static_cast<typename _Traits::comparison_category >(__lhs.compare(__rhs) <=> 0);
+    } else {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130295/new/

https://reviews.llvm.org/D130295



More information about the libcxx-commits mailing list