[libcxx-commits] [PATCH] D129457: [libc++] Simplify __config a bit more and add undersocres

Thu Aug 4 08:26:00 PDT 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Typo in commit message. Also, you might want to say "add underscores to attribute names" just to clarify.

================
Comment at: libcxx/include/__config:689

-#  ifdef _LIBCPP_CXX03_LANG
-#    define _LIBCPP_DECLARE_STRONG_ENUM(x)                                                                             \
----------------
I would like to keep the definition of `_LIBCPP_DECLARE_STRONG_ENUM[_EPILOG]` the way it was. I think it makes sense for simple things like `decltype` and `static_assert` to be bulk-declared like you do above (in the new patch), but for more complicated things like this, it just obscures things out.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129457/new/

https://reviews.llvm.org/D129457