[libcxx-commits] [PATCH] D130853: [libc++] Remove `operator!=` from `type_info` in C++20

Adrian Vogelsgesang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 3 15:45:54 PDT 2022


avogelsgesang added a comment.

> I'm fine with that too, maybe then a separate commit to only add these changes to the status page, when they aren't there yet. That way we don't accidentally forget about them when porting this code to the main library.

sounds good. I will do so, probably next week



================
Comment at: libcxx/include/typeinfo:342
 
     _LIBCPP_INLINE_VISIBILITY
     bool operator!=(const type_info& __arg) const _NOEXCEPT
----------------
Mordante wrote:
> This one should be updated too.
Thanks for catching this! Somehow I assumed there would be only one typeinfo implementation and stopped my search too early...

Is having multiple implementations of the same class a common pattern in libcxx? I know there is a similar pattern for `exception_ptr`. Anything else which is similar (so I am aware of it while updating other classes)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130853/new/

https://reviews.llvm.org/D130853



More information about the libcxx-commits mailing list