[libcxx-commits] [PATCH] D131037: [libc++] Simplify how we define the linker script for libc++

[Dimitry Andric via Phabricator via libcxx-commits]

dim added a comment.

Unfortunately it doesn't really change anything on the FreeBSD build side. It still shows similar output when I put some messages in there:

  DBG: LIBCXX_DEFAULT_ABI_LIBRARY="libcxxrt"
  DBG: LIBCXX_CXX_ABI="libcxxrt"
  -- LIBCXX_CXX_ABI_INCLUDE_PATHS not set, using /usr/include/c++/v1
  -- Looking for cxxabi.h in /usr/include/c++/v1 - found
  -- Looking for unwind.h in /usr/include/c++/v1 - found
  -- Looking for unwind-arm.h in /usr/include/c++/v1 - found
  -- Looking for unwind-itanium.h in /usr/include/c++/v1 - found
  DBG: link_libraries="-l$<IF:$<BOOL:$<TARGET_PROPERTY:libcxx-abi-shared,IMPORTED_LIBNAME>>,$<TARGET_PROPERTY:libcxx-abi-shared,IMPORTED_LIBNAME>,$<TARGET_PROPERTY:libcxx-abi-shared,OUTPUT_NAME>>"
  DBG: linker_script="INPUT($<TARGET_SONAME_FILE_NAME:cxx_shared> -l$<IF:$<BOOL:$<TARGET_PROPERTY:libcxx-abi-shared,IMPORTED_LIBNAME>>,$<TARGET_PROPERTY:libcxx-abi-shared,IMPORTED_LIBNAME>,$<TARGET_PROPERTY:libcxx-abi-shared,OUTPUT_NAME>>)"

and the resulting linker script is still:

  INPUT(libc++.so.1 -l)

This is again likely because `libcxx-abi-shared` is empty, as the default ABI library is libcxxrt, not libcxxabi.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131037/new/

https://reviews.llvm.org/D131037