[libcxx-commits] [PATCH] D130853: [libc++] Remove `operator!=` from `type_info` in C++20

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D130853#3696836 <https://reviews.llvm.org/D130853#3696836>, @Mordante wrote:

> Thanks for working on this!
>
> In D130853#3696297 <https://reviews.llvm.org/D130853#3696297>, @avogelsgesang wrote:
>
>> Note that there are many more classes for which P1614R2 ("The mothership has landed") just removed the `operator!=` (typeinfo, allocator, memory_resource, polymorphic_allocator, bitset, scoped_allocator_adaptor,function, unordered_map, unordered_set, move_sentinel, common_iterator, unreachable_sentinel_t, ...).
>>
>> If you prefer, I could go over all of them in a single commit. Afaict, no test cases need changing, as the `operator!=` will be synthesized by the compiler and all test cases should still pass unchanged.
>
> I think it makes sense to do `typeinfo` separately since that feels a more "sensetive" class.
> We haven't fully implemented to `polymorphic_allocator` allocators yet so they are in the experimental directory. I prefer to do them separately too.
>
> Feel free to do the others in one go. Can you also remove them from `chrono`? I haven't started on them yet.

I'd actually argue that `memory_resource` and `polymorphic_allocator` shouldn't be touched, since they are from LFTSv2 and there the `operator!=` exists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130853/new/

https://reviews.llvm.org/D130853