[libcxx-commits] [PATCH] D130848: [libc++][NFC] Replace macros in vector

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

In general I'm happy with this patch. But I wonder whether this is the best timing. We just landed a big vector patches in the LLVM 15 branch. If we need to backport followup patches this patch might result in conflicts.

Therefore I leave the final approval to @ldionne.



================
Comment at: libcxx/include/vector:358
+    typedef std::reverse_iterator<iterator>               reverse_iterator;
+    typedef std::reverse_iterator<const_iterator>         const_reverse_iterator;
 
----------------
The current change breaks the alignment. Do you intend to switch to `using` in a followup?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130848/new/

https://reviews.llvm.org/D130848