[libcxx-commits] [PATCH] D130845: [libc++] Install clang-tools in the CI container

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 2 10:48:27 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo one nit.



================
Comment at: libcxx/utils/ci/Dockerfile:84
+# Install clang-tools
+RUN apt-get install -y clang-tools-$LLVM_LATEST_VERSION
+RUN ln -s /usr/bin/clang-query-$LLVM_LATEST_VERSION /usr/bin/clang-query && [ -e $(readlink /usr/bin/clang-query) ]
----------------
In Docker you always need to update since the update in the previous layer might be outdated.

While you're at it can you also fix `clang-tidy` and `clang-format` above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130845/new/

https://reviews.llvm.org/D130845



More information about the libcxx-commits mailing list