[libcxx-commits] [PATCH] D130997: [libc++] `uninitialized_copy_result`, `uninitialized_copy_n_result`, `uninitialized_move_n_result` defined in `<memory>`

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const requested changes to this revision.
var-const added a comment.
This revision now requires changes to proceed.

@fsb4000 Thank you for the patch! Would you mind to update the description to something like the following?

  [libc++][NFC] Don't rely on `<algorithm>` transitively including `<memory>` in tests

(The current description identifies the problem; I think it would be clearer to describe the fix instead)



================
Comment at: libcxx/test/std/algorithms/ranges_result_alias_declarations.compile.pass.cpp:17
 #include <algorithm>
+#include <memory>
 #include <type_traits>
----------------
In libc++, `<algorithm>` transitively includes `<memory>`, which must be why we never noticed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130997/new/

https://reviews.llvm.org/D130997