[libcxx-commits] [PATCH] D124555: [libcxx][AIX][z/OS] basic_ios<wchar_t> cannot store fill character WCHAR_MAX

[Sean via Phabricator via libcxx-commits]

SeanP added inline comments.


================
Comment at: libcxx/include/ios:796
 {
+#if defined(_LIBCPP_BASIC_IOS_HAS_FILL_SET)
+    if (!__fill_set_)
----------------
I also noticed these first few lines can be replaced with:
  char_type __r = fill();


================
Comment at: libcxx/include/ios:804
     __fill_ = __ch;
+#if defined(_LIBCPP_BASIC_IOS_HAS_FILL_SET)
+    __fill_set_ = true;
----------------
If you call fill() you don't need to set __fill_set here since fill() will already set it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124555/new/

https://reviews.llvm.org/D124555