[libcxx-commits] [PATCH] D124623: [libc++] Mark tests that use check_assertion.h as requiring unistd.h

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a reviewer: mstorsjo.
Mordante added a comment.

This looks like a nice cleanup in general but it breaks the MinGW builds.



================
Comment at: libcxx/utils/libcxx/test/features.py:119
 
+  Feature(name='has-unistd',
+          when=lambda cfg: sourceBuilds(cfg, """
----------------
I think this name can be a bit more descriptive, for example `has-header-unistd-h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124623/new/

https://reviews.llvm.org/D124623