[libcxx-commits] [PATCH] D124623: [libc++] Mark tests that use check_assertion.h as requiring unistd.h

John Brawn via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 28 09:03:52 PDT 2022


john.brawn created this revision.
john.brawn added reviewers: ldionne, Mordante, michaelplatings.
Herald added subscribers: arphaman, arichardson.
Herald added a project: All.
john.brawn requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

On targets without unistd.h (such as bare metal targets) any test that uses check_assertion.h will fail, so add REQUIRES: has-unistd to them and autodetect whether we have unistd.h or not.

These tests currently have unsupported on windows, but that's exactly because windows doesn't have unistd.h so we can remove the specific check for windows.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124623

Files:
  libcxx/test/libcxx/algorithms/alg.sorting/assert.min.max.pass.cpp
  libcxx/test/libcxx/algorithms/debug_less.inconsistent.pass.cpp
  libcxx/test/libcxx/algorithms/debug_less.pass.cpp
  libcxx/test/libcxx/containers/sequences/array/array.zero/assert.back.pass.cpp
  libcxx/test/libcxx/containers/sequences/array/array.zero/assert.front.pass.cpp
  libcxx/test/libcxx/containers/sequences/array/array.zero/assert.subscript.pass.cpp
  libcxx/test/libcxx/containers/sequences/deque/assert.pop_back.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.cons/debug.copy.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/assert.erase_iter.end.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/assert.pop_back.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.emplace.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.insert.iter_iter_iter.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.insert.iter_rvalue.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.insert.iter_size_value.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.modifiers/debug.insert.iter_value.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.ops/debug.splice.pos_list.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.ops/debug.splice.pos_list_iter.pass.cpp
  libcxx/test/libcxx/containers/sequences/list/list.ops/debug.splice.pos_list_iter_iter.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.back.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.cback.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.cfront.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.cindex.oob.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.front.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.index.oob.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/assert.pop_back.empty.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.add.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.compare.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.decrement.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.index.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/debug.iterator.subtract.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/assert.bucket.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/assert.bucket_size.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/assert.max_load_factor.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.insert.hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.insert.hint_rvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/debug.swap.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/assert.bucket.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/assert.bucket_size.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/assert.max_load_factor.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.insert.hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.insert.hint_rvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.local_iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.local_iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/debug.swap.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/assert.bucket.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/assert.bucket_size.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/assert.max_load_factor.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.insert.hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.local_iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.local_iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/debug.swap.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/assert.bucket.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/assert.bucket_size.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/assert.max_load_factor.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.insert.hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.local_iterator.dereference.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.local_iterator.increment.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/debug.swap.pass.cpp
  libcxx/test/libcxx/debug/containers/associative_containers.pass.cpp
  libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp
  libcxx/test/libcxx/debug/containers/string.pass.cpp
  libcxx/test/libcxx/debug/containers/unord_containers.pass.cpp
  libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/assert.deallocate.pass.cpp
  libcxx/test/libcxx/experimental/memory/memory.resource.adaptor/memory.resource.adaptor.mem/assert.deallocate.pass.cpp
  libcxx/test/libcxx/input.output/filesystems/class.path/path.itr/assert.iterator.pass.cpp
  libcxx/test/libcxx/iterators/assert.advance.pass.cpp
  libcxx/test/libcxx/iterators/assert.next.pass.cpp
  libcxx/test/libcxx/iterators/assert.prev.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.lazy.split/range.lazy.split.inner/assert.equal.pass.cpp
  libcxx/test/libcxx/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer/assert.equal.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.back.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.cback.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.cfront.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.cindex.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.front.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/assert.index.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.add.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.compare.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.decrement.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.dereference.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.increment.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.index.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/debug.iterator.subtract.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/assert.erase_iter.null.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/assert.pop_back.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/debug.erase.iter.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/debug.erase.iter_iter.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/debug.insert.iter_char.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/debug.insert.iter_iter_iter.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/debug.insert.iter_size_char.pass.cpp
  libcxx/test/libcxx/strings/string.view/assert.ctor.pointer.pass.cpp
  libcxx/test/libcxx/thread/futures/futures.promise/assert.set_exception.pass.cpp
  libcxx/test/libcxx/thread/futures/futures.promise/assert.set_exception_at_thread_exit.pass.cpp
  libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/assert.dereference.pass.cpp
  libcxx/test/libcxx/utilities/optional/optional.object/optional.object.observe/assert.op_arrow.pass.cpp
  libcxx/test/support/test.support/test_check_assertion.pass.cpp
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124623.425809.patch
Type: text/x-patch
Size: 75591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220428/301c3ead/attachment-0001.bin>


More information about the libcxx-commits mailing list