[libcxx-commits] [PATCH] D124079: [libc++] Implement ranges::find_end, ranges::search{, _n}

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 28 03:36:22 PDT 2022

philnik added a comment.

In D124079#3479104 <https://reviews.llvm.org/D124079#3479104>, @var-const wrote:

> (Note: this is on my radar but I'll probably won't be able to get to it for a few days)
> Is there a reason to combine these two algorithms in a single patch? Even on their own, each one is sizable, and they don't seem to be dependent on each other or even too closely related.

Which two do you mean? `search` and `find_end` are very similar. I'm even using the random access `search` implementation in `find_end`. If you mean `search_n` and the other two, they are relatively closely related still. Most of the algorithm is almost identical, although they don't share any code in the current implementation.  But if you want I can put `search_n` into it's own PR.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list