[libcxx-commits] [PATCH] D124477: [libc++] Add a few _LIBCPP_ASSERTs in __tree

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 26 14:15:10 PDT 2022


philnik added a comment.

I think I would remove the comments, since the preconditions are now documented in code.



================
Comment at: libcxx/include/__tree:355
 // Precondition:  __root != nullptr && __z != nullptr.
 //                __tree_invariant(__root) == true.
 //                __z == __root or == a direct or indirect child of __root.
----------------
Could you also add that precondition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124477/new/

https://reviews.llvm.org/D124477



More information about the libcxx-commits mailing list