[libcxx-commits] [PATCH] D124122: [libc++] Optimize std::rotate

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D124122#3475473 <https://reviews.llvm.org/D124122#3475473>, @ldionne wrote:

> I'd be fine with this since it addresses the underwhelming performance for simple types like `int`, which is super important. However, I would prefer if we instead went for a better algorithm directly, like the swap/grail rotate algorithm mentioned in https://github.com/llvm/llvm-project/issues/54949#issue-1206295098.

I planned to do a follow-up for that anyways. Would it be OK if I just nuke the current implementation and add the `ranges` API in the same patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124122/new/

https://reviews.llvm.org/D124122