[libcxx-commits] [PATCH] D121074: [libc++] Implement std::boyer_moore{, _horspool}_searcher

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM once CI is green and comments are addressed. I'm fine with the code not being perfect since we're basically copying it from `<experimental/>`. I'm fine (and actually prefer) making changes as follow-up patches.



================
Comment at: libcxx/test/std/utilities/optional/optional.hash/enabled_hash.pass.cpp:28
   }
 
   return 0;
----------------
Please add a release note mentioning that we will remove the experimental version in two releases, i.e. LLVM 17. And also mark the experimental feature as deprecated. This is documented in libcxx/docs/DesignDocs/ExperimentalFeatures.rst.


================
Comment at: libcxx/test/std/utilities/optional/optional.hash/enabled_hash.pass.cpp:30
   return 0;
 }
----------------
Can we tick some boxes in the status pages?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121074/new/

https://reviews.llvm.org/D121074