[libcxx-commits] [PATCH] D124403: [libc++] Refactor max_size.pass.cpp

[Louis Dionne via Phabricator via libcxx-commits]

ldionne updated this revision to Diff 425282.
ldionne marked an inline comment as done.
ldionne edited the summary of this revision.
ldionne added a comment.
Herald added a subscriber: steven.zhang.

Address comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124403/new/

https://reviews.llvm.org/D124403

Files:
  libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp


Index: libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp
===================================================================
--- libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp
+++ libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp
@@ -6,8 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED:
-
 // <string>
 
 // This test ensures that the correct max_size() is returned depending on the platform.
@@ -67,48 +65,28 @@
 }
 
 bool test() {
-#if _LIBCPP_ABI_VERSION == 1
-#ifdef __APPLE__
-
-#  ifdef __aarch64__
-  half_size();
-#  elif defined(__x86_64__)
-  full_size();
-#  else
-#    error "Your target system seems to be unsupported."
-#  endif
 
-#elif defined(__linux__)
+#if _LIBCPP_ABI_VERSION == 1
 
-#  ifdef  __x86_64__
-  full_size();
-#  elif defined(__arm__) || defined(__aarch64__)
-#    ifdef __BIG_ENDIAN__
-  half_size();
-#    else
+# if defined(__x86_64__)
   full_size();
-#    endif
-
-#  else
-#    error "Your target system seems to be unsupported."
-#  endif
-
-#elif defined(__powerpc__)
+# elif defined(__APPLE__) && defined(__aarch64__)
   half_size();
-#elif defined(__powepc64__)
+# elif defined(__arm__) || defined(__aarch64__)
+#   ifdef __BIG_ENDIAN__
   half_size();
-
-#elif defined(_WIN64)
-
-#  ifdef __x86_64__
+#   else
   full_size();
-#  else
-#    error "Your target system seems to be unsupported."
-#  endif
+#   endif
+# elif defined(__powerpc__) || defined(__powerpc64__)
+  half_size();
+# else
+#   error "Your target system seems to be unsupported."
+# endif
 
 #else
-#  error "Your target system seems to be unsupported."
-#endif
+
+  half_size();
 
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124403.425282.patch
Type: text/x-patch
Size: 1744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220426/bed75fb5/attachment.bin>