[libcxx-commits] [PATCH] D124165: [libcxx][AIX] Enable ABI list checking for XCOFF
Jake Egan via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 26 10:20:49 PDT 2022
Jake-Egan marked an inline comment as done.
Jake-Egan added inline comments.
================
Comment at: libcxx/utils/libcxx/sym_check/extract.py:284
+ _, ext = os.path.splitext(lib_file)
+ return True if ext in ['.a'] else False
----------------
ldionne wrote:
> Isn't that equivalent but simpler?
Thanks for the review. I believe `'a' in ext` is the way to simplify because `os.path.splitext()` returns a tuple of size 2.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124165/new/
https://reviews.llvm.org/D124165
More information about the libcxx-commits
mailing list