[libcxx-commits] [PATCH] D124175: [libcxx] Reject month 0 in get_date/__get_month
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 26 08:16:09 PDT 2022
Mordante added a comment.
I'll have another look after the open review comments have been addressed, but the patch looks already nice.
================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp:18
// GLIBC fails on the zh_CN test.
// XFAIL: linux
----------------
DavidSpickett wrote:
> Mordante wrote:
> > :-( This is not your change, but it basically means these changes aren't tested in most of our CI. I'll create a fix.
> Yeah I actually tested this on Linux by commenting out that one test case. So I can at least confirm everything else works.
I just landed D124331, which fixes the tests on Linux. Can you rebase this patch on top of that to see whether the CI is happy too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124175/new/
https://reviews.llvm.org/D124175
More information about the libcxx-commits
mailing list