[libcxx-commits] [PATCH] D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

This change seems ok in principal, but these functions are extern 'C", so now that they're no longer internal linkage they'll provide the same symbol as the real thing. Adding such functions with POSIX reserved names into user program seems like we are asking for trouble. Can we get these moved into some kind of namespace or at least with some kind of double underscore prefix?

(As a side note, _LIBCPP_HIDE_FROM_ABI doesn't exactly work as intend on AIX yet either, as we don't have complete visibility support in clang at the moment. That's something we're actively working on though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124227/new/

https://reviews.llvm.org/D124227