[libcxx-commits] [PATCH] D124165: [libcxx][AIX] Enable ABI list checking for XCOFF

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with a few nitpicks. I checked a CI run on AIX and it seems like we are indeed running the `check-cxx-abilist` target on it now.



================
Comment at: libcxx/utils/libcxx/sym_check/extract.py:284
+         _, ext = os.path.splitext(lib_file)
+         return True if ext in ['.a'] else False
 
----------------
Isn't that equivalent but simpler?


================
Comment at: libcxx/utils/libcxx/sym_check/extract.py:289
     Extract and return a list of symbols extracted from a static or dynamic
-    library. The symbols are extracted using NM or readelf. They are then
-    filtered and formated. Finally they symbols are made unique.
+    library. The symbols are extracted using dump, NM or readelf. They are
+    then filtered and formated. Finally the symbols are made unique.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124165/new/

https://reviews.llvm.org/D124165