[libcxx-commits] [PATCH] D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 25 06:23:31 PDT 2022
philnik marked an inline comment as done.
philnik added inline comments.
Comment at: libcxx/include/__bit_reference:1115
+ using reference = typename conditional<_IsConst, bool, __bit_reference<_Cp>>::type;
> Hi. This line causes breakages when compiling with `-std=c++03`:
> /include/libcxx/__bit_reference:1115:79: error: a space is required between consecutive right angle brackets (use '> >')
> using reference = typename conditional<_IsConst, bool, __bit_reference<_Cp>>::type;
> Could you please fix this?
Fixed it in 6b257a. Just out of interest, why do you use the unstable ABI in C++03? It's clearly not for ABI reasons. Also as a side note: I don't think we officially support using the unstable ABI pre-C++11, so you should probably not use that combination. But the fix is simple enough.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits