[libcxx-commits] [PATCH] D124372: [libunwind] [CMake] Remove leftover no-op cmake variable setting. NFC.

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 25 03:36:04 PDT 2022

mstorsjo created this revision.
mstorsjo added reviewers: phosek, MaskRay.
Herald added subscribers: StephenFan, mgorny.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
mstorsjo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The setting and restoring of this variable became unused in
3ee0cec88effc88285732c8bec2a8f0e4e37c0b1 <https://reviews.llvm.org/rG3ee0cec88effc88285732c8bec2a8f0e4e37c0b1> / D112155 <https://reviews.llvm.org/D112155>.

  rG LLVM Github Monorepo



Index: libunwind/CMakeLists.txt
--- libunwind/CMakeLists.txt
+++ libunwind/CMakeLists.txt
@@ -180,15 +180,6 @@
 # Setup Compiler Flags
-# Compiler tests may be failing if the compiler implicitly links in libunwind,
-# which doesn't exist yet. This gets waived by --unwindlib=none
-# later in config-ix below, but the tests for --target etc before that may
-# be failing due to it. Only test compilation, not linking, for these
-# tests here now.
 # Configure compiler.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124372.424857.patch
Type: text/x-patch
Size: 844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220425/c0bcc73f/attachment.bin>

More information about the libcxx-commits mailing list