[libcxx-commits] [PATCH] D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD

[Brad Smith via Phabricator via libcxx-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGd13f5023891c: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD (authored by brad).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122628/new/

https://reviews.llvm.org/D122628

Files:
  libcxx/docs/ReleaseNotes.rst
  libcxx/include/__config


Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -350,7 +350,8 @@
 //      Use rand_s(), for use on Windows.
 //      When this option is used, the token passed to `std::random_device`'s
 //      constructor *must* be "/dev/urandom" -- anything else is an error.
-#if defined(__OpenBSD__) || defined(__APPLE__)
+#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || \
+    defined(__OpenBSD__) || defined(__DragonFly__)
 #  define _LIBCPP_USING_ARC4_RANDOM
 #elif defined(__wasi__)
 #  define _LIBCPP_USING_GETENTROPY
Index: libcxx/docs/ReleaseNotes.rst
===================================================================
--- libcxx/docs/ReleaseNotes.rst
+++ libcxx/docs/ReleaseNotes.rst
@@ -97,6 +97,11 @@
   ``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` will not be honoured anymore and there
   will be no way to opt back into the C++03 emulation of ``std::nullptr_t``.
 
+- On FreeBSD, NetBSD and DragonFlyBSD, ``std::random_device`` is now implemented on top of
+  ``arc4random()`` instead of reading from ``/dev/urandom``. Any implementation-defined
+  token used when constructing a ``std::random_device`` will now be ignored instead of
+  interpreted as a file to read entropy from.
+
 Build System Changes
 --------------------
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122628.424806.patch
Type: text/x-patch
Size: 1365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220425/2fca03b9/attachment.bin>