[libcxx-commits] [PATCH] D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 24 10:34:06 PDT 2022


ldionne accepted this revision.
ldionne added a subscriber: libc++ vendors.
ldionne added a comment.
This revision is now accepted and ready to land.

Looking at this and D122861 <https://reviews.llvm.org/D122861> again, it strikes me that perhaps the goal was for these to be valid when compiling as C. However, I think that might be a non-goal since one should simply not have libc++ in the header search paths when compiling as C.

So this LGTM, but pinging vendors for awareness. I suggest you ship this if nobody objects within a week or so, just to avoid stalling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124227/new/

https://reviews.llvm.org/D124227



More information about the libcxx-commits mailing list