[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/include/exception:102
+#if defined(_LIBCPP_ABI_VCRUNTIME) && (!defined(_HAS_EXCEPTIONS) || _HAS_EXCEPTIONS != 0)
+// The std::exception class was already included above, but we're explicit about this condition here for clarity
+
----------------
Super minor nit


================
Comment at: libcxx/include/exception:117
+public:
+  // This constructor is necessary to compile header new for the _HAS_EXCEPTIONS==0 scenario
+  explicit exception(const char* _Message = "unknown", int = 1) _NOEXCEPT : _Ptr(_Message) {}
----------------
Super minor nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947