[libcxx-commits] [PATCH] D124328: [libc++] Forward more often to memmove in copy

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 23 08:21:06 PDT 2022


philnik added a comment.

In D124328#3469921 <https://reviews.llvm.org/D124328#3469921>, @xbolva00 wrote:

>>> Fixes https://github.com/llvm/llvm-project/issues/33687
>
> What exactly? For the testcases, I see two memmoves with libc++:
>
> https://gcc.godbolt.org/z/GeWf6b179

This now unwraps even weird stuff like `reverse_iterator<reverse_iterator<int*>>`. It also unwraps `reverse_iterator<std::vector<int>::iterator>` properly (and combinations). In D122982 <https://reviews.llvm.org/D122982> I disabled the `std::vector<int>::iterator` unwrapping accidentally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124328/new/

https://reviews.llvm.org/D124328



More information about the libcxx-commits mailing list