[libcxx-commits] [PATCH] D124123: [libc++] Remove <functional> includes

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 23 01:07:50 PDT 2022

philnik added a comment.

@var-const What would you like to see in the description? The consensus was that we remove a few of the transitive includes in the libc++15 release cycle.
I don't think that Louis has to take a look here, since he approved of the direction. The entire reason this is in it's own patch is to be able to easily revert it just in case we break something in a really bad way.

Comment at: libcxx/docs/ReleaseNotes.rst:71
+- Some libc++ headers no longer transitively include all of
+    - ``<algorithm>``,
+    - ``<chrono>``,
var-const wrote:
> Optional: I think it's more common for list elements to end in `;` semicolons.
I think it makes more sense to remove them entirely.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list