[libcxx-commits] [PATCH] D124123: [libc++] Remove <functional> includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the cleanup.



================
Comment at: libcxx/docs/ReleaseNotes.rst:74
+  source files now needs to ``#include <algorithm>``, ``#include <chrono>``,
+  ``#include <functional>`` and/or ``#include <utility>``.
 
----------------
I feel this list is getting at the point were it becomes hard to read, and I expect the list to keep growing. I would suggest to change this entry to
```
- Some libc++ headers no longer transitively include all of
  
  - ``<algorithm>``,
  - ``<chrono>``,
  - ``<functional>``, and
  - ``<utility>``.

  If, after updating libc++, you see compiler errors related to missing declarations in namespace ``std``,
  it might be because one of your source files now needs to include one or more of the above headers.
```
(The formatting is untested.)

If you want to keep it as is, then please add Oxford comma's in both listings. (The first also misses a space.)
```
``<functional>``, and ``<utility>``. If, after updating libc++, you see compiler errors
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124123/new/

https://reviews.llvm.org/D124123