[libcxx-commits] [PATCH] D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion.



================
Comment at: libcxx/test/std/containers/sequences/vector.bool/types.pass.cpp:27
 //     typedef std::reverse_iterator<const_iterator>    const_reverse_iterator;
+//     using const_reference = bool;
 // };
----------------
For consistency I would use a typedef here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123851/new/

https://reviews.llvm.org/D123851