[libcxx-commits] [PATCH] D122536: [libc++] Optimize `exception_ptr`, especially for the empty case

[Fabian Wolff via Phabricator via libcxx-commits]

fwolff marked 6 inline comments as done.
fwolff added inline comments.


================
Comment at: libcxx/src/exception.cpp:9-11
+#if !defined(_LIBCPP_ABI_MICROSOFT) && !defined(__GLIBCXX__)
+#define _LIBCPP_EXCEPTION_PTR_GNU_INLINE /*empty*/
+#endif
----------------
philnik wrote:
> Why do you guard the macro definition here? Could you add a short comment here why you are defining this?
I think this was wrong; the macro definition can be unguarded and we unfortunately need more preprocessor guards in the `exception` header, because the glibcxx ABI doesn't have `__incr/decr_refcount()`...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122536/new/

https://reviews.llvm.org/D122536