[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/include/exception:141
+protected:
+    const char* _Ptr; 
+};
----------------
paulkirth wrote:
> phosek wrote:
> > I wonder if we should annotate this with `[[maybe_unused]]` to avoid a compiler warning.
> That may be a good idea. Grep didn't reveal a macro that I saw, but I may have missed it. I do see that this file has a `_LIBCPP_DIAGNOISTIC_IGNORED(-Wunused-private-field)` maybe that is the correct approach here w/ a change to the warning?
> 
> 
I'd prefer defining a new macro, e.g. `_LIBCPP_MAYBE_UNUSED`, akin to `_NOEXCEPT` which would expand to `[[maybe_unused]]` (or `__attribute__((unused))` if `[[maybe_unused]]` is unavailable).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947